Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check the PR milestone matches the upcoming draft release. #81

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 10, 2024

When the PR is milestoned, we also check, but don't have access to the draft release. Instead, we check against the local version, which we check against the draft release in another check run.


This change is Reviewable

@iphydf iphydf requested a review from a team as a code owner November 10, 2024 23:00
@github-actions github-actions bot added the enhancement New feature for the user, not a new feature for build script label Nov 10, 2024
@iphydf iphydf force-pushed the check-release branch 2 times, most recently from 8e157eb to 297225c Compare November 10, 2024 23:03
@iphydf iphydf modified the milestones: master, v0.8.1 Nov 10, 2024
@iphydf iphydf force-pushed the check-release branch 3 times, most recently from cb7bff5 to 6ab80f7 Compare November 10, 2024 23:31
When the PR is milestoned, we also check, but don't have access to the
draft release. Instead, we check against the local version, which we
check against the draft release in another check run.
@toktok-releaser toktok-releaser merged commit 81d0896 into TokTok:master Nov 10, 2024
9 checks passed
@iphydf iphydf deleted the check-release branch November 10, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants