Optimize auto prune routine #1208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SquidXTV
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
In order to keep helper roles below 250 users, we have a routine that removes a role from a more inactive user.
The old implementation used
Guild#findMembersWithRolesto filter for them, which surprisingly requests allmembers first and does the filtering on the client. This happens for each role (about 17). So we basically query the same
content multiple times. The new implementation requests all members beforehand and then reusing it to prune roles if needed.
This is related to the issue about a
TimeoutExceptionon the member chunk requests when requesting all members. This doesn't mean it is going to fix that issue, but it is still an optimization.