[#137] fix: findByOauthInfo Optional로 변경 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관 이슈
작업내용
upsert를 구현하기 위해 Domain Service에서
@Transactional을 사용하고,try catch로 UserNotFoundException을 catch 하였으나,
port 내에서 exception 발생하면서 롤백 마킹 되어,
원래 진행되고있는 메소드에서 catch 하여도 롤백이 되는 현상 발생.
관련하여 찾아보고 noRollbackFor을 적용하였으나 해결되지 않아 우선 Optional로 처리