Return empty ArrayBuffer if returnRawBuffers is true (#58)

* If there are no results for an attribute return empty ArrayBuffer if returnRawBuffers is true * Build lib * Add tests for empty attributes
TileDB-Inc · Feb 10, 2023 · d10352a · d10352a
1 parent 9c98415
commit d10352a
Show file tree

Hide file tree

Showing 4 changed files with 69 additions and 4 deletions.
diff --git a/lib/utils/getResultsFromArrayBuffer.js b/lib/utils/getResultsFromArrayBuffer.js
diff --git a/lib/utils/getResultsFromArrayBuffer.js.map b/lib/utils/getResultsFromArrayBuffer.js.map
diff --git a/src/utils/getResultsFromArrayBuffer.test.ts b/src/utils/getResultsFromArrayBuffer.test.ts
@@ -43,7 +43,6 @@ describe("getResultsFromArrayBuffer()", () => {
       nullableVarLengthAttrBufferHeaders,
       varLenNullableAttributesSchema
     );
-    // expect(results).toEqual("");
 
     expect(results).toEqual({
       a1: [100, null, null, 400],
@@ -53,4 +52,61 @@ describe("getResultsFromArrayBuffer()", () => {
       rows: [1, 1, 2, 2],
     });
   });
+
+  it("Should return empty array if there are no results if attributebuffers are empty", async () => {
+    const file = path.join(__dirname, "../fixtures/nullable_buffer.raw");
+    const rawBuffer = readFileSync(file);
+    const arrayBufferOfFixedLengthAttributes =
+      convertToArrayBufferIfNodeBuffer(rawBuffer);
+
+      const attributeBufferHeaders = [
+        {
+          name: "cols",
+          fixedLenBufferSizeInBytes: 0,
+          varLenBufferSizeInBytes: 0,
+          validityLenBufferSizeInBytes: 0,
+          originalFixedLenBufferSizeInBytes: 0,
+          originalVarLenBufferSizeInBytes: 0,
+          originalValidityLenBufferSizeInBytes: 0,
+        }
+      ]
+
+    const results = await getResultsFromArrayBuffer(
+      arrayBufferOfFixedLengthAttributes,
+      attributeBufferHeaders,
+      varLenNullableAttributesSchema
+    );
+
+    expect(results).toEqual({ cols: []});
+  });
+
+  it("Should return empty ArrayBuffer if no results and returnRawBuffers is true", async () => {
+    const file = path.join(__dirname, "../fixtures/nullable_buffer.raw");
+    const rawBuffer = readFileSync(file);
+    const arrayBufferOfFixedLengthAttributes =
+      convertToArrayBufferIfNodeBuffer(rawBuffer);
+
+      const attributeBufferHeaders = [
+        {
+          name: "cols",
+          fixedLenBufferSizeInBytes: 0,
+          varLenBufferSizeInBytes: 0,
+          validityLenBufferSizeInBytes: 0,
+          originalFixedLenBufferSizeInBytes: 0,
+          originalVarLenBufferSizeInBytes: 0,
+          originalValidityLenBufferSizeInBytes: 0,
+        }
+      ]
+
+    const results = await getResultsFromArrayBuffer(
+      arrayBufferOfFixedLengthAttributes,
+      attributeBufferHeaders,
+      varLenNullableAttributesSchema,
+      {
+        returnRawBuffers: true
+      }
+    );
+
+    expect(results).toEqual({ cols: new ArrayBuffer(0)});
+  });
 });
diff --git a/src/utils/getResultsFromArrayBuffer.ts b/src/utils/getResultsFromArrayBuffer.ts
@@ -57,7 +57,11 @@ export const getResultsFromArrayBuffer = async (
       const offset = await offsetPromise;
 
       if (!totalNumberOfBytesOfAttribute) {
-        data[attribute.name] = [];
+        if (options.returnRawBuffers) {
+          data[attribute.name] = new ArrayBuffer(0);
+        } else {
+          data[attribute.name] = [];
+        }
 
         return offset;
       }