Add another example to the wikify widget : use core svg to show an icon next to links #8806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: DesignThinkerer has already signed the Contributor License Agreement (see contributing.md) |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Jermolene
reviewed
Dec 8, 2024
| @@ -44,3 +44,7 @@ The available output types are: | |||
| !! Exporting rendered html | |||
|
|
|||
| <<testcase "TestCases/WikifyWidget/RenderHTML">> | |||
|
|
|||
| !! Rendering parametrized svg for use in stylesheets | |||
There was a problem hiding this comment.
There's a typo, but our house style is to generally use British English spellings.
There was a problem hiding this comment.
Sorry about that! I fixed it.
|
Thanks @DesignThinkerer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding icons to links is something rather popular among users, so showing a way to do it without the need for any plugin seems fitting as an example for the doc.
Aside: I tried to apply the stylesheet by using $:/tags/Stylesheet but it didn't work. Is this intentional ?
Submitted using https://saqimtiaz.github.io/tw5-docs-pr-maker/.