Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake8 error in local test #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −7
Open

fix flake8 error in local test #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Source = "https://github.com/Thriftpy/thriftpy2"

[project.optional-dependencies]
dev = [
"flake8>=2.5",
"flake8>=4.0",
"sphinx-rtd-theme>=0.1.9",
"sphinx>=1.3",
"pytest-reraise",
Expand Down
9 changes: 7 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ universal = 1

[flake8]
filename = *.py, *.pyx
max-line-length = 80
max-line-length = 100
exclude =
setup.py,
.git,
Expand All @@ -13,6 +13,8 @@ exclude =
dist,
.tox,
venv*
.venv
tests
ignore =
# Ambiguous variable names
E741
Expand All @@ -26,4 +28,7 @@ ignore =
# E251: Unexpected spaces around keyword / parameter equals (types in function definitions)
# E402: module level import not at top of file
# E999: Internal AST compilation error (flake8 specific)
per-file-ignores = *.pyx: E211,E225,E226,E227,E251,E402,E999
per-file-ignores =
*.pyx: E211,E225,E226,E227,E251,E402,E999
apache_json.py: E226,E501
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add the description for the newly added error names above, around line 30, while respecting the order.

*/cybin/__init__.py: F401,F403
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last \n is needed.

5 changes: 1 addition & 4 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ commands =
py.test

deps =
attrs==20.3.0; python_version == '3.4'
typing; python_version == '3.4'
pytest>=6.1.1,<8.2.0
pytest-reraise
coverage
Expand All @@ -23,8 +21,7 @@ deps =

[testenv:flake8]
deps =
flake8
flake8-per-file-ignores
flake8>=4.0
commands = flake8 .
changedir = .

Expand Down