Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments, docs and tests #273

Merged
merged 1 commit into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ Version 0.4.5
Released on August 27, 2019.

- Support kwargs style parameters passing in TSimpleServer, via `2-#67`_.
- Fix #65 allow double const to ommit integer part, via `2-#66`_.
- Fix #65 allow double const to omit integer part, via `2-#66`_.

.. _2-#67: https://github.com/Thriftpy/thriftpy2/pull/67
.. _2-#66: https://github.com/Thriftpy/thriftpy2/pull/66
Expand Down Expand Up @@ -461,7 +461,7 @@ Released on April 15, 2015.
- add limitation on thrift reserved keyword for compatible with upstream, via
`#115`_.
- bugfix EOF grammar error, via `#103`_.
- bugfix for mis-mach transport in client caused server crash, via `#119`_.
- bugfix for mismatch transport in client caused server crash, via `#119`_.
- bugfix for typedef on included thrift files, via `#121`_.

.. _`#96`: https://github.com/eleme/thriftpy/pull/96
Expand All @@ -487,7 +487,7 @@ Released on March 3, 2015.
- bugfix for transport clean in read_struct in cybin, via `#70`_.
- bugfix for large reading size in framed transport, via `#73`_.
- bugfix for cython build failed in older CentOS, via `#92`_.
- bugfix for thrift file version mis-match caused message corrupt in
- bugfix for thrift file version mismatch caused message corrupt in
`read_struct`, via `#95`_.

Non-Backward Compatible changes:
Expand Down Expand Up @@ -719,7 +719,7 @@ Released on June 7, 2014.
- disabled the magic import hook by default. and add install/remove
function to switch the hook on and off.
- reworked benchmark suit and add benchmark results.
- new `__init__` function code generator. get a noticable speed boost.
- new `__init__` function code generator. get a noticeable speed boost.
- bug fixes


Expand Down
2 changes: 1 addition & 1 deletion tests/addressbook.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-

"""This file is a demo for what the dynamiclly generated code would be like.
"""This file is a demo for what the dynamically generated code would be like.
"""

from thriftpy2.thrift import (
Expand Down
2 changes: 1 addition & 1 deletion tests/compatible/version_2/tracking.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(self, request_id, api, seq, client, server, status, start,
:status: request status
:start: start timestamp
:end: end timestamp
:annotation: application-level key-value datas
:annotation: application-level key-value data
"""
self.request_id = request_id
self.api = api
Expand Down
2 changes: 1 addition & 1 deletion tests/container.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-

"""This file is a demo for what the dynamiclly generated code would be like.
"""This file is a demo for what the dynamically generated code would be like.
"""

from thriftpy2.thrift import (
Expand Down
2 changes: 1 addition & 1 deletion tests/test_rpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def test_exception():
c.remove("Bob")


def test_exception_iwth_ssl():
def test_exception_with_ssl():
with pytest.raises(addressbook.PersonNotExistsError):
with ssl_client() as c:
c.remove("Bob")
Expand Down
2 changes: 1 addition & 1 deletion thriftpy2/contrib/tracking/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def __init__(self, request_id, api, seq, client, server, status, start,
:status: request status
:start: start timestamp
:end: end timestamp
:annotation: application-level key-value datas
:annotation: application-level key-value data
"""
self.request_id = request_id
self.api = api
Expand Down
2 changes: 1 addition & 1 deletion thriftpy2/hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


# TODO: The load process does not compatible with Python standard, e.g., if the
# specified thrift file does not exists, it raises FileNotFoundError, and skiped
# specified thrift file does not exists, it raises FileNotFoundError, and skipped
# the other meta finders in the sys.meta_path.
class ThriftImporter(importlib.abc.MetaPathFinder):
def __init__(self, extension="_thrift"):
Expand Down
4 changes: 2 additions & 2 deletions thriftpy2/parser/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ def parse(path, module_name=None, include_dirs=None, include_dir=None,
the `include` directive, by default: ['.'].
:param include_dir: directory to find child thrift files. Note this keyword
parameter will be deprecated in the future, it exists
for compatiable reason. If it's provided (not `None`),
for compatible reason. If it's provided (not `None`),
it will be appended to `include_dirs`.
:param lexer: ply lexer to use, if not provided, `parse` will new one.
:param parser: ply parser to use, if not provided, `parse` will new one.
Expand Down Expand Up @@ -614,7 +614,7 @@ def parse_fp(source, module_name, lexer=None, parser=None, enable_cache=True):
<module 'note_thrift' (built-in)>

:param source: file-like object, expected to have a method named `read`.
:param module_name: the name for parsed module, shoule be endswith
:param module_name: the name for parsed module, should be endswith
'_thrift'.
:param lexer: ply lexer to use, if not provided, `parse` will new one.
:param parser: ply parser to use, if not provided, `parse` will new one.
Expand Down
2 changes: 1 addition & 1 deletion thriftpy2/transport/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def read(self, sz):

def write(self, buf):
"""
Submit some data to tbe written to the connection. May be
Submit some data to be written to the connection. May be
buffered until flush is called.
"""
raise NotImplementedError
Expand Down
Loading