-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version 0.4.18 #236
Bump version 0.4.18 #236
Conversation
WalkthroughVersion 0.4.18 brings enhancements for Python 3.12 compatibility, improved string decoding options, expanded type annotations, and fixes for oneway requests. The update also adjusts Python version support in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- CHANGES.rst (1 hunks)
- setup.py (1 hunks)
- thriftpy2/init.py (1 hunks)
Files skipped from review due to trivial changes (1)
- thriftpy2/init.py
Additional comments: 3
setup.py (2)
- 108-108: The addition of Python 3.12 to the classifiers correctly reflects the PR's objective to support the latest Python version. This change ensures that the package metadata accurately represents the supported Python versions.
- 98-111: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [13-14]
The
tornado_requires
list has been updated to include a specific version range for Python 3.12. This change is crucial for ensuring compatibility with Python 3.12, as it specifies the versions of Tornado that are compatible with the new Python version. However, it's important to verify that Tornado versions specified for Python 3.12 (>=4.0,<7.0
) are indeed compatible and do not introduce any breaking changes or incompatibilities with ThriftPy2.CHANGES.rst (1)
- 7-14: The changes listed for version 0.4.18 in the
CHANGES.rst
file accurately reflect the PR objectives and the AI-generated summary. This includes compatibility enhancements for Python 3.12, the introduction of astrict_decode
option, support forUnion
type annotations, and a fix formessage_type
in oneway requests. It's important that these changes are well-documented and communicated to users, as they significantly impact the software's functionality and compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- CHANGES.rst (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- CHANGES.rst
Prepare to release v0.4.18.