Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version 0.4.18 #236

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Bump version 0.4.18 #236

merged 2 commits into from
Feb 27, 2024

Conversation

aisk
Copy link
Member

@aisk aisk commented Feb 25, 2024

Prepare to release v0.4.18.

Copy link

coderabbitai bot commented Feb 25, 2024

Walkthrough

Version 0.4.18 brings enhancements for Python 3.12 compatibility, improved string decoding options, expanded type annotations, and fixes for oneway requests. The update also adjusts Python version support in setup.py to align with current standards.

Changes

Files Change Summary
CHANGES.rst, setup.py - Updated import hook for Python 3.12 compatibility, added strict_decode option, allowed Union type annotations, fixed message_type in oneway requests
- Updated Python version support to include 3.12 and remove 3.4 support
thriftpy2/__init__.py - Updated version number from '0.4.17' to '0.4.18'

🐇✨
In the land of code, where the snippets roam free,
A new version hops in, as lively as can be.
With Python 3.12 in its sight,
It leaps and bounds with all its might.
Fixes here and features there,
A rabbit's work, done with care.
🎉🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@aisk aisk requested a review from ethe February 25, 2024 11:19
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e0847d7 and 8d977c6.
Files selected for processing (3)
  • CHANGES.rst (1 hunks)
  • setup.py (1 hunks)
  • thriftpy2/init.py (1 hunks)
Files skipped from review due to trivial changes (1)
  • thriftpy2/init.py
Additional comments: 3
setup.py (2)
  • 108-108: The addition of Python 3.12 to the classifiers correctly reflects the PR's objective to support the latest Python version. This change ensures that the package metadata accurately represents the supported Python versions.
  • 98-111: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [13-14]

The tornado_requires list has been updated to include a specific version range for Python 3.12. This change is crucial for ensuring compatibility with Python 3.12, as it specifies the versions of Tornado that are compatible with the new Python version. However, it's important to verify that Tornado versions specified for Python 3.12 (>=4.0,<7.0) are indeed compatible and do not introduce any breaking changes or incompatibilities with ThriftPy2.

CHANGES.rst (1)
  • 7-14: The changes listed for version 0.4.18 in the CHANGES.rst file accurately reflect the PR objectives and the AI-generated summary. This includes compatibility enhancements for Python 3.12, the introduction of a strict_decode option, support for Union type annotations, and a fix for message_type in oneway requests. It's important that these changes are well-documented and communicated to users, as they significantly impact the software's functionality and compatibility.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8d977c6 and 8beffc8.
Files selected for processing (1)
  • CHANGES.rst (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGES.rst

@aisk aisk merged commit 1f6cad4 into Thriftpy:master Feb 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants