Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Spawn trait #634

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Rewrite Spawn trait #634

wants to merge 10 commits into from

Conversation

Thomasdezeeuw
Copy link
Owner

This splits it into two traits: SpawnLocal and Spawn. SpawnLocal is for
thread-local actors and futures, while Spawn is for thread-safe.

Closes #311

@Thomasdezeeuw
Implement From<&RuntimeRef> for ThreadLocal
2b40823
@Thomasdezeeuw
Add ActorOptions::as_future_options
c16a075 
Returns itself as FutureOptions.
@Thomasdezeeuw
Rewrite Spawn trait
ea3e1df 
This splits it into two traits: SpawnLocal and Spawn. SpawnLocal is for
thread-local actors and futures, while Spawn is for thread-safe.
@Thomasdezeeuw
Add more From impls for Thread{Local,Safe}
abe54f1 
To make SpawnLocal and Spawn more usable.
@Thomasdezeeuw
Test Sync implements Spawn
7d667bb
@Thomasdezeeuw
Update tests and example
1b77ebe
@Thomasdezeeuw
Ignore clippy::cast_lossless in trace value conversions
0b12b28
@Thomasdezeeuw
Rename ActorOptions::as_future_options to into_
a1d1f60 
Matching the common naming scheme.
@Thomasdezeeuw
Copy link
Owner Author

Need to fix the name implementation for Process for futures, now it always returns FutureProcess making it useless.

@Thomasdezeeuw
Copy link
Owner Author

Also need to look at whether the double catching of panics will cause (performance) issues.

@Thomasdezeeuw
Small doc fixes & improvements
6491cac
@Thomasdezeeuw
Put building of ActorFuture in a single function
94e19de 
So we don't have to duplicate the code when adding new ActorOptions.
@Thomasdezeeuw
Copy link
Owner Author

TODO:

  • Fix name of the process when spawning ActorFutures. Maybe requires Process to be specialised?
  • Don't double catch_unwind.
  • Still like a generic SpawnWherever trait that doesn't concern itself about being local or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve usability of the Spawn trait
1 participant
@Thomasdezeeuw