-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add German descriptions to metadata and update English descriiption #99
Conversation
|
Sorry, I do not sign any CLAs – that's not my understanding of the FOSS idea. I stick to the project's license. If that's a no-go for you, feel free to copy-paste and close the PR. I like to give back to FOSS projects, but if CLAs are a condition that's a show-stopper for me.
Sorry to disappoint you, but luckily FOSS projects requiring me to sign a CLA are the absolute exception– I didn't find "many". Look at the number of projects I've contributed to at Github alone. Yours is only the second one asking me for that (the other one gave me that note in advance, so I didn't even care to open a PR. That was years ago, so I cannot even remember which project it was). I respect it (you will have your reasons), but I usually do not contribute if that's the condition. |
Hi Izzy, Thanks for the PR! I'll merge this and begin working on a UI localization in German for the strings in the app as well. I'll ping you when it's ready in case you'd be interested in helping with QA. I understand your reservations on the CLA, in our case this is just to protect the firm from certain liabilities and provenance requirements and is not meant to punish contributors. It's intended mainly for code and intellectual property contributions, so I can waive the requirement for signing it for this MR since it's just strings/metadata. |
Also, congrats! You are the first external contributor to an OpenAthena project 😄. The updated descriptions will be most helpful for users |
If you need to split up the description into multiple lines again, try sticking to "standard Markdown" compatible formatting (i.e. separating paragraphs by empty lines between them, bullet point lists by an empty line before and after, etc). You can leave "simple HTML" inside. It will then format the same with my repo (which on pull will convert it back) and still OK with F-Droid. Further such formatting hints can be found in my Wiki on Fastlane formattings (which are focused on F-Droid repos) if needed.
Sure, I gladly cross-check!
I understand that for a company – but it makes it difficult for folks like me who do not "mass contribute" to a single project, but bits and pieces here and there. Luckily…
That was my hope. And could you have not, I gave my explicit consent to copy-paste which you can screenshot and ArchiveOrg if needed. Call it selfish if you like: I just wanted to improve how your app ipresentedin MY repo 🙈
Wow, didn't expect that – thanks! And yes, "being helpful" was the intention. People should get a basic understanding already by description and screenshots, without much "hunting for details". So thanks for merging! The English one will be synced to my repo with your next release then. |
As discussed in #96, here're the German descriptions from my repo plus the updated English one I had here before, giving some more details. I've made it two separate commits so you can cherry-pick when needed.
full_description.txt
is "compressed HTML" for reasons outlined in the issue: HTML gives better formatting, and putting it all in one line keeps F-Droid software from inserting additional<br>
for each empty line.