-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Markdown Documentation of Android Casting Structure #174
base: master
Are you sure you want to change the base?
Conversation
Markdown Documentation describing the main casting functionality within OpenAthena Android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. Provides a decent overview of some of the major components of the app. Better description of the role of the AthenaApp singleton, AthenaActivity abstract class and children, and the rest of the activities may be needed
@@ -0,0 +1,105 @@ | |||
# OpenAthena Android Core Functionality | |||
Core Casting Functionality within OA Android is defined by 3 main classes: MetaDataExtractor, DEMParser, and TargetGetter. | |||
These classes are managed by the AthenaApp and MainActivity classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The association here presents a bit of a false equivalency. AthenaApp is a singleton for managing persistent app state, while MainActivity, DEM Activity, FullscreenSelectionActivity, etc. extend the AthenaActivity abstract class. AthenaActivity manages the behavior of subclasses much more than AthenaApp
+ minArcAngle() | ||
+ radNormalize() | ||
+ degNormalize() | ||
+ azumuthToUnitCircle() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, 'azumuth' -> azimuth
|
||
``` | ||
### MainActivity and AthenaApp | ||
These main components are managed by the MainActivity and AthenaApp classes. MainActivity can be considered the entry point for all major actions within OpenAthena. Metadata extraction, DEM management, and target acquisition all take place within MainActivity. Activities may not be persistent across the life of the application, so AthenaApp is used to hold all state information persistently across activities. It is for this reason that both TargetGetter and AthenaApp contain a DEMParser object, with the persistent object being passed to TargetGetter as necessary. These classes do not contribute to the actual casting functionality, but manage the casting functionality within Android. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And AthenaActivity abstract class and its static variables
Basic markdown file containing class diagrams and descriptions for the core casting engine within OpenAthena Android.