Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions - Handle non-ASCII characters gracefully #519

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Extensions - Handle non-ASCII characters gracefully #519

merged 1 commit into from
Apr 25, 2022

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Apr 25, 2022

When merged this pull request will:

  • Fix crash found by @Lairdd1989 with Armory item descriptions containing non-ASCII whitespaces.
  • Replace non-ASCII characters with [INVALID-CHAR] so it can be fixed in Armory itself as well.

@jonpas jonpas added the bug fix label Apr 25, 2022
@jonpas jonpas added this to the 1.32.2 milestone Apr 25, 2022
@jonpas jonpas requested a review from Flyzoor April 25, 2022 12:53
@jonpas jonpas changed the title Extensions - Handle Armory non-ASCII characters gracefully Extensions - Handle non-ASCII characters gracefully Apr 25, 2022
@jonpas jonpas merged commit 763f484 into master Apr 25, 2022
@jonpas jonpas deleted the apollo-client-non-ascii branch April 25, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flyzoor Flyzoor Awaiting requested review from Flyzoor

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
1.32.2
Development

Successfully merging this pull request may close these issues.
1 participant
@jonpas