Úpravy anket #24
Merged
Úpravy anket #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New emoji class, inherited from Enum this time - Corrected embeds and errors for using the new emoji style - main.py has debug logger now - Now you can add new options using new button known bugs: - Raising errors in buttons/modals doesn't work properly due to a bug in attributes. Maybe raise an issue on discord.py pages Signed-off-by: robertsokola <[email protected]>
This was
linked to
issues
Jul 3, 2023
Try to make a embed that displays whether a user added a new option Signed-off-by: robertsokola <[email protected]>
Signed-off-by: robertsokola <[email protected]>
|
Je potřeba přepsat db, momentálně db využívá date místo datetime. TODO pro příště. |
…t commit should aim for tasks.loop and database overlay fixes. Signed-off-by: robertsokola <[email protected]>
oprava pomoci black
TheXer
commented
Jul 28, 2023
cogs/poll_command.py
Outdated
| @@ -64,22 +64,34 @@ async def transform(self, interaction: discord.Interaction, date_time: str) -> d | |||
|
|
|||
|
|
|||
| class PollCreate(commands.Cog): | |||
| POLL_PARAMETERS = { | |||
There was a problem hiding this comment.
Tohle nakonec potřeba není, můžeš toto smazat. Přijdeme na jiný způsob jak to udělat, teď bychom se měli zaměřit jen na vytvoření anket, kdy se anketa smaže a pak pošle embed s hlasy.
|
Do tohoto PR přidán bugfix pro #29 |
- fixed bug with databases where two people clicking at the same time could break entire bot - added new functionality with looping, where the bot can check if the embed is due date - added new transformer for transferring dates, it's a little more dumbproof than previous versions - added new error handling... more beautiful! Signed-off-by: robertsokola <[email protected]>
Signed-off-by: robertsokola <[email protected]>
|
@Martian-0007 Půjdeš otestovat všechnu funkcionalitu, zda všechno jede jak má? :) |
Signed-off-by: robertsokola <[email protected]>
TheXer
added a commit
that referenced
this pull request
Sep 3, 2023
Hlavní pull-request na to, aby se nakonec všechny věci zrecenzovaly a byly na jednom místě, než tyto věci dáme na produkci. Co je nového? - #16 - #21 - #23 - #24 - Optimalizace hlasování - #29 - Vytvořena CI pipeline Co dál dělat? - Počkat, až bude PR #24 hotový, teprve pak můžeme kód otestovat a mergnout ho. Kdo si zaslouží dík? - @Martian-0007 Díky moc! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request míří na úpravu anket podle issues. Zejména se jedná o tyto věci:
Tyto změny by měly obecně prospět anketám a byly by mnohem přehlednější.
Související issues:
TODO:
raisekeyword automaticky nepošle error.