fix: infinite loop on category swipe #167
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes infinite loop on quick emoji list scroll behavior reported in issue
Changes:
In the previous implementation, after scrolling between EmojiCategories using gesture, when
setActiveCategory
was called insideonScrollEnd
method,useEffect
callback withscrollToIndex
was fired withactiveCategoryIndex
that the list was already at. Quick scrolling back and forth with gesture was causing infinite state updates between current and previousactiveCategoryIndex
es. To fix that behavior while leaving ability to browse EmojiCategories using CategoryItem pressscrollToIndex
is now called directly insideCategoryItem