Don't update gcode scripts if gcode script obvservables are still und…

…efined. This occurs when settings hasn't been in opened such as the wizard.
TheThief · Feb 1, 2021 · d2e2a74 · d2e2a74
1 parent 89a27b8
commit d2e2a74
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/octoprint_smartpreheat/static/js/smartpreheat.js b/octoprint_smartpreheat/static/js/smartpreheat.js
@@ -20,9 +20,11 @@ $(function() {
         };
 
         self.onSettingsBeforeSave = function () {
-            if (self.scripts_gcode_snippets_doSmartPreheat() != self.settings.scripts.gcode["snippets/doSmartPreheat"]()) {
-                self.settings.plugins.smartpreheat.scripts_gcode_snippets_doSmartPreheat = self.scripts_gcode_snippets_doSmartPreheat;
-                self.settings.scripts.gcode["snippets/doSmartPreheat"](self.scripts_gcode_snippets_doSmartPreheat());
+            if (self.scripts_gcode_snippets_doSmartPreheat() !== undefined) {
+                if (self.scripts_gcode_snippets_doSmartPreheat() != self.settings.scripts.gcode["snippets/doSmartPreheat"]()) {
+                    self.settings.plugins.smartpreheat.scripts_gcode_snippets_doSmartPreheat = self.scripts_gcode_snippets_doSmartPreheat;
+                    self.settings.scripts.gcode["snippets/doSmartPreheat"](self.scripts_gcode_snippets_doSmartPreheat());
+                }
             }
         };
     }