Skip to content

Commit

Permalink
remove port 5959, as IPC is used by default
Browse files Browse the repository at this point in the history
via

```
Christien Rioux
@crioux

This won't work.

EXPOSE 5959 is dangerous, IPC is used by default these days. veilid-cli should just be run as an exec into the docker image.

Dockerfiles to build images, if they are well-vetted should be checked into the veilid repository not the documentation.

This is should not be merged.

```
  • Loading branch information
naisanzaa committed Jul 21, 2024
1 parent 55631f7 commit 22441fb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ VOLUME /logs
VOLUME /var/db/veilid-server

# listen_address
EXPOSE 5959
# IPC is used by default
#EXPOSE 5959

# grpc_endpoint
EXPOSE 4317
Expand Down
6 changes: 4 additions & 2 deletions veilid-server
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ if [ -z "$@" ]; then
-v veilid-server-logs:/logs \
-v veilid-server-data:/var/db/veilid-server \
--restart always \
ghcr.io/theshellland/veilid-node:latest --set-config 'client_api.listen_address="0.0.0.0:5959"' $@
ghcr.io/theshellland/veilid-node:latest \
$@
else
docker run -d --name veilid-node --net veilid \
-v veilid-server-config:/config \
Expand All @@ -23,5 +24,6 @@ else
-v veilid-server-data:/var/db/veilid-server \
-p 5959:5959 \
--restart always \
ghcr.io/theshellland/veilid-node:latest --set-config 'client_api.listen_address="0.0.0.0:5959"' $@
ghcr.io/theshellland/veilid-node:latest \
$@
fi

0 comments on commit 22441fb

Please sign in to comment.