Don't report connection still alive after close without Client.disconnect #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nect previously, due to an oversight, closing the connection through a means other than calling the function Client.disconnect (i.e. computer suspending, server dying) would cause AP.js's state machine to still report that it was connected to the server. This fixes that by moving much of the deinitialization logic in Client.disconnect to a new disconnection listener which is established in Client.#finalizeConnection (so that it only gets called when the stuff we want to deinitialize is definitely present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, closing the connection through any means other than calling the function Client.disconnect (i.e. computer suspending, server dying) would cause AP.js's state machine to still report that it was connected to the server. This fixes that by moving much of the deinitialization logic in Client.disconnect to a new disconnection listener which is established in Client.#finalizeConnection (so that it only gets called for fully initialized socket data).