Set ItemManager index to correct value after ReceivedItems #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is likely no longer necessary with the v2 rewrite that I just posted today, but I may publish a 1.2 release just to patch some of these old bugs, so I'll keep this PR open for a bit to come back to. |
|
I submitted these PRs with that intention, yes. |
ThePhar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in the CrossCode APWorld that every time an item was received, my client would send a
SyncPacket and the server would, naturally, respond with aReceivedItemspacket withindex=0. This turned out to be an oversight inItemsManager.#onReceivedItemsin which the program would fail to update#indexto the new value, therefore keeping#indexconstantly at zero, and creating some unnecessary network bandwidth. This PR adds a whopping one line of code that should fix this issue.