Fix bug where open access titles in ODL feeds would fail to import (P…

…P-847) (#147) * Fix bug where open access titles in ODL feeds would fail to import. * Lint files * Fix test descriptions.
ThePalaceProject · Jan 17, 2024 · 42af1cb · 42af1cb
1 parent c6cd0b2
commit 42af1cb
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 2 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,5 +1,5 @@
 [build-system]
-build-backend = "poetry.masonry.api"
+build-backend = "poetry.core.masonry.api"
 requires = ["poetry-core>=1.0.0"]
 
 [tool.isort]

diff --git a/src/webpub_manifest_parser/odl/semantic.py b/src/webpub_manifest_parser/odl/semantic.py
@@ -196,7 +196,7 @@ def visit(self, node):
         self._logger.debug(f"Started processing {encode(node)}")
 
         if (not node.licenses or len(node.licenses) == 0) and (
-            (not node.licenses or len(node.links) == 0)
+            (not node.links or len(node.links) == 0)
             or not node.links.get_by_rel(OPDS2LinkRelationsRegistry.OPEN_ACCESS.key)
         ):
             with self._record_errors():

diff --git a/tests/webpub_manifest_parser/odl/test_semantic.py b/tests/webpub_manifest_parser/odl/test_semantic.py
@@ -186,6 +186,38 @@ class ODLSemanticAnalyzerTest(AnalyzerTest):
                     )
                 ],
             ),
+            (
+                "when_publication_does_not_contain_licenses_and_has_a_oa_link",
+                ODLFeed(
+                    metadata=OPDS2FeedMetadata(title="test"),
+                    links=LinkList(
+                        [
+                            Link(
+                                href="http://example.com",
+                                rels=[LinkRelationsRegistry.SELF.key],
+                            )
+                        ]
+                    ),
+                    publications=CollectionList(
+                        [
+                            ODLPublication(
+                                metadata=PresentationMetadata(title="Publication 1"),
+                                links=LinkList(
+                                    [
+                                        Link(
+                                            href="http://example.com",
+                                            rels=[
+                                                OPDS2LinkRelationsRegistry.OPEN_ACCESS.key
+                                            ],
+                                        )
+                                    ]
+                                ),
+                            )
+                        ]
+                    ),
+                ),
+                [],
+            ),
             (
                 "when_license_does_not_contain_self_link_and_borrow_link",
                 ODLFeed(