Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Commit

Permalink
Code review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathangreen committed Jun 18, 2024
1 parent 6970ea8 commit 00d68ab
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion tests/files/odl/feed.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"state": "unavailable",
"until": "2000-05-04T03:02:01Z",
"detail": "a detailed reason",
"reason": "http://terms.example.org/unavailable"
"reason": "https://registry.opds.io/reason#exhausted"
}
},
"links": [
Expand Down
2 changes: 1 addition & 1 deletion tests/files/opds2/feed.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"language": "en",
"availability": {
"state": "unavailable",
"reason": "https://example.com/subscription/removal",
"reason": "https://registry.opds.io/reason#removed",
"detail": "This publication is no longer available in your subscription",
"since": "2019-09-29T01:03:02Z"
},
Expand Down
3 changes: 2 additions & 1 deletion tests/webpub_manifest_parser/odl/test_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ def test(self):
)
self.assertEqual("a detailed reason", license.metadata.availability.detail)
self.assertEqual(
"http://terms.example.org/unavailable", license.metadata.availability.reason
"https://registry.opds.io/reason#exhausted",
license.metadata.availability.reason,
)

self.assertEqual(2, len(license.links))
Expand Down
2 changes: 1 addition & 1 deletion tests/webpub_manifest_parser/opds2/test_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def test(self):
)
self.assertEqual(
publication.metadata.availability.reason,
"https://example.com/subscription/removal",
"https://registry.opds.io/reason#removed",
)
self.assertIs(publication.metadata.time_tracking, True)

Expand Down

0 comments on commit 00d68ab

Please sign in to comment.