Update the fetch-lcp command to have two subcommands #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e manifest and one to fetch the underlying LCP file and lcpl license file.
jonathangreen
force-pushed
the
feature/fetch-lcp-updates
branch
from
74efcae to
d95a41f
Compare
jonathangreen
commented
Mar 6, 2024
| None, help="Password to present to the OPDS server." | ||
| ), | ||
| username: str = typer.Option(..., "--username", "-u", help="Username or barcode."), | ||
| password: str = typer.Option(None, "--password", "-p", help="Password or PIN."), |
There was a problem hiding this comment.
Updated these to match the fetch_lcp command, since one took args and one took options. Was a bit confusing when using the two commands back to back.
| @@ -1,6 +1,6 @@ | |||
| # Some defaults | |||
| DEFAULT_ASYNC_TIMEOUT = 30.0 | |||
| DEFAULT_AUTH_DOC_PATH_SUFFIX = "/authentication-document" | |||
| DEFAULT_AUTH_DOC_PATH_SUFFIX = "authentication_document" | |||
There was a problem hiding this comment.
This needed to be updated to be able to use the OPDS Server Heuristic args to patron-bookshelf.
| if link.properties | ||
| else None | ||
| ): | ||
| print(f" LCP hashed passphrase: {hashed_pw}") |
There was a problem hiding this comment.
This is useful to have included in the output for the bookshelf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One that fetches a manifest, and one that fetches the lcp and lcpl files.