Add option to upload result to s3 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernstein
force-pushed
the
add-option-to-upload-result-to-s3
branch
from
8990a4f to
936fe8e
Compare
tdilauro
approved these changes
Nov 1, 2023
Comment on lines
+207
to
+212
| help="An S3 bucket to save the results to. If specified, you must also specify a result-key", | ||
| ) | ||
| @click.option( | ||
| "--result-key", | ||
| required=False, | ||
| help="An S3 object key to save the results to. If used, result-bucket must be specified.", |
There was a problem hiding this comment.
Should we check result_bucket and result_key are both provided, if either is provided and emit a helpful error message, if not?
Comment on lines
+134
to
+143
| @click.option( | ||
| "--result-bucket", | ||
| required=False, | ||
| help="An S3 bucket to save the results to. If specified, you must also specify a result-key", | ||
| ) | ||
| @click.option( | ||
| "--result-key", | ||
| required=False, | ||
| help="An S3 object key to save the results to. If used, result-bucket must be specified.", | ||
| ) |
There was a problem hiding this comment.
Should we check result_bucket and result_key are both provided, if either is provided and emit a helpful error message, if not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains changes to support passing dashboard info generated by terraform driven scripts to downstream ansible scripts.
So this PR adds the ability:
These features are invoked here.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-516
https://github.com/ThePalaceProject/hosting-playbook/pull/518
How Has This Been Tested?
Changes are covered by updates to existing unit tests.
Checklist