Skip to content

Commit

Permalink
Make optionals explicit.
Browse files Browse the repository at this point in the history
  • Loading branch information
dbernstein committed Dec 8, 2023
1 parent dbee3bb commit fbfd67f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion core/cli.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
from typing import Optional

import boto3
import click
Expand Down Expand Up @@ -220,7 +221,7 @@ def import_and_publish(
group_name: str,
result_bucket: str,
result_key: str,
output_json: str = None,
output_json: Optional[str] = None,
):

log.info(f"import_and_publish")
Expand Down
5 changes: 3 additions & 2 deletions core/operation/publish_dashboard_from_template.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import json
import time
from typing import Optional

from core.operation.baseoperation import BaseOperation

Expand All @@ -17,8 +18,8 @@ def __init__(
result_bucket: str,
result_key: str,
s3_client,
dashboard_alias: str = None,
output_json: str = None,
dashboard_alias: Optional[str] = None,
output_json: Optional[str] = None,
*args,
**kwargs,
):
Expand Down

0 comments on commit fbfd67f

Please sign in to comment.