Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle OPDS server root content types. (PP-1959) #718

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

tdilauro
Copy link
Collaborator

@tdilauro tdilauro commented Dec 4, 2024

Description

  • Loosens content media type checking from exact string match to matching on a type prefix and a minimal set of type directives.
  • Adds a normalized media type class that can be applied to other URL matching in the future.
  • Adds some test cases to cover some that were previously missing.

NB: Note that some linter checks failed. The linter was changing some things that were unrelated to this PR, so I removed them for now. Once this PR is reviewed, I'll add the changes from the linter. I have added these changes.

Motivation and Context

Palace Manager #2142 introduced a change in the feed content types and this PR is aimed at catching up with those changes.

[Jira PP-1959]

How Has This Been Tested?

Checklist

  • N/A I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from a team December 4, 2024 22:02
@tdilauro tdilauro added the bug Something isn't working label Dec 4, 2024
Copy link
Contributor

@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀 🐎 🐰

@tdilauro tdilauro merged commit e9e2a58 into main Dec 5, 2024
8 checks passed
@tdilauro tdilauro deleted the bugfix/handle-opds-content-type-variants branch December 5, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants