Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack dev-server handling of relative URLs. (PP-690) #11

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tdilauro
Copy link
Collaborator

@tdilauro tdilauro commented Nov 6, 2023

Description

Corrects handling of relative URLs by the webpack dev-server.

Motivation and Context

dev-server was failing on relative URLs. This manifest itself in the form of an error after logging into an admin account:

NetworkError when attempting to fetch resource.

[Jira PP-690]

How Has This Been Tested?

  • Manually tested in a local development environment.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from ray-lee November 6, 2023 18:18
@tdilauro tdilauro changed the title Fix webpack dev-server handling of relative links. (PP-690) Fix webpack dev-server handling of relative URLs. (PP-690) Nov 6, 2023
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tdilauro tdilauro merged commit a24441d into main Nov 7, 2023
2 checks passed
@tdilauro tdilauro deleted the bugfix/devserver-relative-links branch November 7, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants