Ensures that the time tracking report can be successfully uploaded to… #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernstein
force-pushed
the
fix-s3-upload-on-timetracking-email
branch
from
5cc1ddc to
a3d2020
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2220 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 363 363
Lines 41284 41286 +2
Branches 8838 8839 +1
=======================================
+ Hits 37616 37618 +2
Misses 2406 2406
Partials 1262 1262 ☔ View full report in Codecov by Sentry. |
jonathangreen
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… s3.
This is an update to the time tracking email ticket that converted attachments to s3 links. This update fixes a problem we were having with uploading a text io stream to S3.
Description
Motivation and Context
How Has This Been Tested?
I tested this change directly on dev to make sure it worked before creating the PR.
Checklist