Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a misleading test. #2215

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix a misleading test. #2215

merged 1 commit into from
Dec 18, 2024

Conversation

tdilauro
Copy link
Contributor

Description

Fixes a test that only appeared to be working.

Motivation and Context

While working on PP-1875, I noticed this test, which happened to be passing only because the associated library had only a single collection.

How Has This Been Tested?

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from a team December 18, 2024 02:50
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (ec00a8e) to head (a9b1e04).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2215      +/-   ##
==========================================
+ Coverage   91.09%   91.11%   +0.02%     
==========================================
  Files         363      363              
  Lines       41201    41274      +73     
  Branches     8827     8837      +10     
==========================================
+ Hits        37531    37606      +75     
  Misses       2406     2406              
+ Partials     1264     1262       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdilauro tdilauro merged commit d311474 into main Dec 18, 2024
21 checks passed
@tdilauro tdilauro deleted the fix/misleading-passing-test branch December 18, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants