[PP-1947] convert attachments to s3 links #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernstein
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2209 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 363 363
Lines 41268 41274 +6
Branches 8837 8837
=======================================
+ Hits 37600 37606 +6
Misses 2406 2406
Partials 1262 1262 ☔ View full report in Codecov by Sentry. |
jonathangreen
approved these changes
Dec 12, 2024
|
|
||
| def update_bucket_expiration_rule( | ||
| self, prefix: str, expiration_in_days: int = 30 | ||
| ) -> None: |
There was a problem hiding this comment.
Minor: Seems like this might be something we want to just do in our terraform config, instead of doing it every time we do an inventory report. We already apply a lifecycle rule to expire multipart uploads.
| prefix=f"{reports_path}/", expiration_in_days=expiration_in_days | ||
| ) | ||
|
|
||
| with zip_path.open( |
There was a problem hiding this comment.
Minor: Instead of opening the file again here, I'm fairly sure that report_zip is a IO[bytes], which store_stream can take directly.
dbernstein
force-pushed
the
PP-1947-convert-attachments-to-s3-links
branch
from
c7313c9 to
fe5dc35
Compare
…move bucket lifecycle configuration to terraform.
dbernstein
force-pushed
the
PP-1947-convert-attachments-to-s3-links
branch
from
fe5dc35 to
f452d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update changes the way we are delivering inventory and holds reports. Instead of attaching the zipped reports to an email we are instead providing a link in the email to the zip which lives in public s3 bucket. The zip file will be removed automatically after 30 days.
The url contains a UUID in order ensure that the email link is not guessable and to ensure that it is uniquely associated with the email request. In addition the zip file name includes the library short name as well as the date range covered by the request.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1947
How Has This Been Tested?
Unit tests cover it but it has not yet been tested in dev.
Checklist