Handle Overdrive refresh_patron_access_token failues (PP-1964)

[jonathangreen]

Description

Previously in refresh_patron_access_token we were only handling the cases for status_code 200 and 400. Everything else would just pass through the function without doing anything.

After this update any 2xx status code will be counted as a success, and any other status code will fail patron auth, log a useful error message and return a ProblemDetail document to the client.

I added a test case with a real API failure error from Overdrive, and added another test case to make sure we correctly handle unexpected responses.

Motivation and Context

We were seeing unhandled exceptions in Exception in web app: Something's wrong with the patron OAuth Bearer Token on our webservers reasonably frequently. This appears to be happening when Overdrive is not happy with a patrons auth for some reason.

How Has This Been Tested?

• Tested locally

Checklist

• I have updated the documentation accordingly.
• All new and existing tests passed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (8d10cab) to head (30e3c3c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2188      +/-   ##
==========================================
+ Coverage   91.05%   91.07%   +0.02%     
==========================================
  Files         363      363              
  Lines       41218    41220       +2     
  Branches     8847     8843       -4     
==========================================
+ Hits        37530    37542      +12     
+ Misses       2417     2408       -9     
+ Partials     1271     1270       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tdilauro]

🎉