Helper function to get flask.request.admin #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
==========================================
+ Coverage 91.00% 91.01% +0.01%
==========================================
Files 359 361 +2
Lines 41136 41193 +57
Branches 8842 8845 +3
==========================================
+ Hits 37436 37493 +57
Misses 2424 2424
Partials 1276 1276 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
tdilauro
approved these changes
Nov 20, 2024
| @@ -61,7 +62,8 @@ def process_get(self) -> Response: | |||
|
|
|||
| for library in libraries: | |||
| # Only include libraries this admin has librarian access to. | |||
| if not flask.request.admin or not flask.request.admin.is_librarian(library): # type: ignore[attr-defined] | |||
| admin = get_request_admin(default=None) | |||
There was a problem hiding this comment.
Change request: We should move this assignment outside of the loop.
jonathangreen
force-pushed
the
chore/type-hint-request-admin
branch
from
1440954 to
774e56f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #2177 but for
flask.request.admin.Add a helper function get_request_admin() to get
flask.request.adminin a type safe way. Update the existing code to use the new helper.Motivation and Context
Consistency in how we are accessing attributes set on
flask.request.How Has This Been Tested?
Checklist