Replace webpub manifest parser with pydantic (PP-1367) #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
feature/replace-webpub-manifest-parser
branch
from
6f7438a to
2ae2600
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2163 +/- ##
==========================================
+ Coverage 90.87% 91.00% +0.12%
==========================================
Files 359 359
Lines 41263 41136 -127
Branches 8883 8842 -41
==========================================
- Hits 37498 37436 -62
+ Misses 2476 2424 -52
+ Partials 1289 1276 -13 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jonathangreen
changed the title
This was referenced Nov 13, 2024
jonathangreen
force-pushed
the
feature/replace-webpub-manifest-parser
branch
from
4a9279d to
50fc11c
Compare
jonathangreen
changed the base branch from
main
to
feature/add-pydantic-opds-models
jonathangreen
force-pushed
the
feature/add-pydantic-opds-models
branch
from
399768d to
1ca1dce
Compare
jonathangreen
force-pushed
the
feature/replace-webpub-manifest-parser
branch
from
da3e71a to
8101188
Compare
jonathangreen
force-pushed
the
feature/replace-webpub-manifest-parser
branch
from
8101188 to
bed6d49
Compare
tdilauro
approved these changes
Nov 20, 2024
|
|
||
| contributor_metadata = ContributorData( | ||
| sort_name=contributor.sort_as, | ||
| display_name=contributor.name, | ||
| display_name=str(contributor.name), |
There was a problem hiding this comment.
Hmmm. Maybe just food for future thought here, but this makes me realize that, at least for some properties (like contributors), it might not make sense for name to be a LanguageMap. But maybe it does (e.g., in the case of corporate authors, which might need a translation).
I note also that the schema calls for a string or a language map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace our custom web manifest parser with Pydantic models.
I replace the validation we were doing via a patched json schema with the pydantic parser, since it gives better errors and more closely matches what we are expecting in Palace.
Edit: I broke this one into two PRs to make it a little easier to review. This PR actually implements the new models in our existing code, #2168 adds the models.
Motivation and Context
JIRA: PP-1367
Note: After this one goes in we should cut a new release of https://github.com/ThePalaceProject/webpub-manifest-parser and then mark it as archived, since we won't be using it anymore.
How Has This Been Tested?
Checklist