Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enki integration URL generation (PP-1876) #2155

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

jonathangreen
Copy link
Member

Description

It looks like the URL setting changes when we upgraded Pydantic were causing the Enki integration to generate incorrect URLs (missing slash). I added a helper function to generate the URL and added a test for this case.

Motivation and Context

Enki integration not working, see: PP-1876.

How Has This Been Tested?

  • Unit tests
  • Tested locally

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen added the bug Something isn't working label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (1707ece) to head (934afe5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2155   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         350      350           
  Lines       40608    40610    +2     
  Branches     8796     8796           
=======================================
+ Hits        36864    36866    +2     
  Misses       2439     2439           
  Partials     1305     1305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen requested a review from a team November 5, 2024 16:11
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ 🔧

@jonathangreen jonathangreen merged commit 91609a2 into main Nov 6, 2024
21 checks passed
@jonathangreen jonathangreen deleted the bugfix/enki-urls branch November 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants