Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Axis 360 response parser exception code mapping. #2151

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Nov 1, 2024

Description

Fixes a duplicate key in the Axis 360 ResponseParser's code_to_exception map.

Motivation and Context

I noticed this while poking around for PP-818-related stuff.

How Has This Been Tested?

Checklist

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro added the bug Something isn't working label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (7457a46) to head (8cb5fbf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2151      +/-   ##
==========================================
+ Coverage   90.68%   90.77%   +0.09%     
==========================================
  Files         350      350              
  Lines       40607    40607              
  Branches     8796     8796              
==========================================
+ Hits        36826    36863      +37     
+ Misses       2458     2439      -19     
+ Partials     1323     1305      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@tdilauro tdilauro merged commit fed3447 into main Nov 2, 2024
21 checks passed
@tdilauro tdilauro deleted the bugfix/axis360-exception-code-mapping branch November 2, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants