-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PP-1818] implement month active user data #2148
Conversation
dbf50ac
to
939a5f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2148 +/- ##
=======================================
Coverage 90.78% 90.79%
=======================================
Files 350 351 +1
Lines 40693 40718 +25
Branches 8822 8824 +2
=======================================
+ Hits 36942 36968 +26
Misses 2441 2441
+ Partials 1310 1309 -1 ☔ View full report in Codecov by Sentry. |
8146920
to
776d725
Compare
f85e074
to
44aefa9
Compare
You may have considered this already, but while looking into PP-1863, I was reminded that we have a credential type of Credential.IDENTIFIER_TO_REMOTE_SERVICE that might be suitable for this purpose or as a template for associating an identifier with a patron, but without modifying the patron table. Sorry to lob in a hand grenade 💣 at this stage. Feel free to do -- or not do ("There is no try?") -- what you will with this information. |
… hints and docstrings
44aefa9
to
8d94a75
Compare
@tdilauro : I appreciate your suggestion. And I like it. I can't think of a good reason not to do it that way other than that I did it this way and it works and is done and I feel like I need to move on. But I suppose if we wanted to rework it in the future it would not be a heavy lift to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎸
Description
This update includes the following changes:
/patrons/me/erase_activity_history
endpoint.Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1818
How Has This Been Tested?
Checklist