Clear PatronData.authorization_expires if it is no longer set #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
bugfix/patron-authorization-expires
branch
from
120ee02 to
1d1f996
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2147 +/- ##
=======================================
Coverage 90.77% 90.77%
=======================================
Files 350 350
Lines 40607 40607
Branches 8796 8796
=======================================
Hits 36863 36863
Misses 2439 2439
Partials 1305 1305 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a ILS once reported that a patron has an expiry, but stops reporting that date, currently we don't clear the previous information. This change will let us clear that info, so patrons don't get stuck with an expired card that the ILS cannot clear.
Motivation and Context
Probably the issue in: https://ebce-lyrasis.atlassian.net/browse/SUP-232
How Has This Been Tested?
Checklist