Handle StaleDataError for ODLNotificationController #2129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch
StaleDataError
when processing ODL update. This can happen when a loan gets deleted by another process while the ODL notification controller is running. This has the possiblity of happening when we are locally deleting the loan for a returned book, and also receive a callback from the LCP server.Motivation and Context
Handle a fairly rare race condition with the
ODLNotificationController
. I've seen it happen in my testing a couple of times, but not every time.How Has This Been Tested?
Checklist