Remove deprecated ODL notify endpoint 🧹 #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
changed the title
jonathangreen
force-pushed
the
chore/remove-deprecated-endpoint
branch
from
06a11b6 to
61917fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚨 This one shouldn't be merged until #2117 is in a release and has been rolled out, so that the old endpoint stays active until all the old loans expire. I'll leave this in draft until then, just wanted to get a PR ready so we don't forget to remove it.
This PR removes the
odl_notifyendpoint that was deprecated in #2117Motivation and Context
Cleanup 🧹
How Has This Been Tested?
Checklist