Refactor LoanInfo and HoldInfo to be dataclasses (PP-1728) #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
+ Coverage 90.69% 90.72% +0.02%
==========================================
Files 351 351
Lines 40878 40878
Branches 8858 8853 -5
==========================================
+ Hits 37073 37085 +12
+ Misses 2493 2486 -7
+ Partials 1312 1307 -5 ☔ View full report in Codecov by Sentry. |
jonathangreen
commented
Oct 16, 2024
|
This one has some missing coverage, but all the lines that are not covered, we not previously covered, so I think it should be fine to merge as is. |
jonathangreen
force-pushed
the
chore/refactor-loan-hold-info
branch
from
d490e4b to
4e69c0c
Compare
dbernstein
approved these changes
Oct 16, 2024
src/palace/manager/api/axis.py
Outdated
| def process_one(self, e: _Element, namespaces: dict[str, str] | None) -> LoanInfo: | ||
| def process_one( | ||
| self, e: _Element, namespaces: dict[str, str] | None | ||
| ) -> datetime.datetime | None: | ||
| """Either turn the given document into a LoanInfo |
There was a problem hiding this comment.
It looks like the doc needs to be updated
src/palace/manager/api/odl/api.py
Outdated
| holdinfo = HoldInfo.from_license_pool( | ||
| licensepool, | ||
| start_date=utc_now(), | ||
| end_date=None, |
There was a problem hiding this comment.
Can this line be removed since None is the default for end date?
Comment on lines
1088
to
1090
| start_date=None, | ||
| end_date=None, | ||
| hold_position=None, |
There was a problem hiding this comment.
Can these lines be removed since None is the default for start_date, end_date and hold_position?
| None, | ||
| hold_info = HoldInfo.from_license_pool( | ||
| licensepool, | ||
| start_date=None, |
src/palace/manager/api/overdrive.py
Outdated
| licensepool.identifier.type, | ||
| licensepool.identifier.identifier, | ||
| return HoldInfo.from_license_pool( | ||
| licensepool, | ||
| start_date=start_date, | ||
| end_date=None, |
Comment on lines
314
to
315
| start_date=None, | ||
| end_date=None, |
Comment on lines
358
to
359
| start_date=None, | ||
| end_date=None, |
| LoanInfo.from_license_pool( | ||
| pool, | ||
| start_date=utc_now(), | ||
| end_date=None, |
Comment on lines
182
to
183
| start_date=None, | ||
| end_date=None, |
Comment on lines
190
to
191
| start_date=None, | ||
| end_date=None, |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
LoanInfoandHoldInfoto be simple dataclasses, and move the logic for creating and updating loans and holds from aLoanInfoorHoldInfointo a method calledcreate_or_update.In the process, I removed the
Hold.external_identifiercolumn, which appears to be unused.Motivation and Context
Needed to modify how
LoanInfoandHoldInfoare used as part of PP-1728, this refactor makes that work easier, but I thought it would be easier to understand as a separate PR.How Has This Been Tested?
Checklist