Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the fixture for creating collections #2101

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

jonathangreen
Copy link
Member

Description

Update the fixture for creating collections, similar to the integration configuration fixture, so its easy to just pass a class name in as the protocol when creating a collection. Also remove the set_settings function, and replace it with the new collection functionality.

Motivation and Context

Needed to create a number of collections for testing and getting the protocol names was more difficult then it should have been.

How Has This Been Tested?

  • Tested in CI

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team October 4, 2024 00:47
@jonathangreen jonathangreen marked this pull request as ready for review October 4, 2024 12:12
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (e54575f) to head (81efa9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
- Coverage   90.65%   90.65%   -0.01%     
==========================================
  Files         344      344              
  Lines       40581    40580       -1     
  Branches     8822     8822              
==========================================
- Hits        36790    36787       -3     
- Misses       2484     2485       +1     
- Partials     1307     1308       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen force-pushed the chore/update-collection-db-fixture branch from 19fce73 to 81efa9d Compare October 4, 2024 12:27
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🛠️

@jonathangreen jonathangreen merged commit fd6f008 into main Oct 5, 2024
20 checks passed
@jonathangreen jonathangreen deleted the chore/update-collection-db-fixture branch October 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants