Remove unused Overdrive credentials from the database #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2061 +/- ##
=======================================
Coverage 90.65% 90.65%
=======================================
Files 344 344
Lines 40581 40581
Branches 8822 8822
=======================================
Hits 36790 36790
Misses 2484 2484
Partials 1307 1307 ☔ View full report in Codecov by Sentry. |
jonathangreen
force-pushed
the
chore/overdrive-cleanup-migration
branch
from
b0611eb to
de734c9
Compare
jonathangreen
force-pushed
the
chore/overdrive-cleanup-migration
branch
from
de734c9 to
06204db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small follow up to #2060 to delete the credentials from the database that we stopped using in that PR.
🚨 This is ready for a code review, but it shouldn't get merged until #2060 is in a release. I'll keep it in draft until then.
Motivation and Context
🧹 cleanup
How Has This Been Tested?
Checklist