Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celery logging config #1904

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Celery logging config #1904

merged 4 commits into from
Jun 14, 2024

Conversation

jonathangreen
Copy link
Member

Description

Its possible for the log level config to be None so we get an exception when accessing levelno. This just adds a None check.

Motivation and Context

Fix a minor bug I noticed in while testing #1894.

How Has This Been Tested?

Running tests.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen added the bug Something isn't working label Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.28%. Comparing base (f372958) to head (29228cd).
Report is 1 commits behind head on main.

Files Patch % Lines
src/palace/manager/celery/app.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
+ Coverage   90.16%   90.28%   +0.11%     
==========================================
  Files         325      332       +7     
  Lines       39701    39867     +166     
  Branches     8645     8647       +2     
==========================================
+ Hits        35798    35994     +196     
+ Misses       2597     2578      -19     
+ Partials     1306     1295      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen requested a review from a team June 13, 2024 19:15
@jonathangreen
Copy link
Member Author

Codecov is complaining about this one, but the line it wants tested is pretty difficult to actually test. I think this one is fine to go in as is.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jonathangreen jonathangreen merged commit 47c1dc0 into main Jun 14, 2024
19 of 20 checks passed
@jonathangreen jonathangreen deleted the bugfix/celery-logging-config branch June 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants