Remove patron.last_loan_activity_sync #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1897 +/- ##
=======================================
Coverage 90.28% 90.28%
=======================================
Files 332 332
Lines 39865 39870 +5
Branches 8647 8649 +2
=======================================
+ Hits 35991 35996 +5
Misses 2581 2581
Partials 1293 1293 ☔ View full report in Codecov by Sentry. |
jonathangreen
force-pushed
the
feature/patron-activity-task
branch
4 times, most recently
from
a83fc20 to
87caa2f
Compare
jonathangreen
force-pushed
the
feature/patron-activity-followup-migration
branch
from
0d61b94 to
e976011
Compare
|
@tdilauro it just needed a rebase since the base branch changed when the other merged. Its up to date now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the patron.last_loan_activity_sync column that is no longer being removed.
🚨 this one shouldn't get merged until #1894 goes into a release. I'll leave this in draft until then.
Motivation and Context
Follow up migration for #1894.
How Has This Been Tested?
Checklist