Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run script path for custom list update script #1878

Merged
merged 1 commit into from
May 30, 2024

Conversation

jonathangreen
Copy link
Member

Description

Fix the run script path for the custom list update script.

Motivation and Context

I missed when I did the revert that the path for the run script has changed from core/bin/run to bin/run, so the custom list update script isn't running.

How Has This Been Tested?

N/A

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen added the bug Something isn't working label May 30, 2024
@jonathangreen jonathangreen requested a review from a team May 30, 2024 19:10
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (56ce2dc) to head (b913157).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1878   +/-   ##
=======================================
  Coverage   90.11%   90.12%           
=======================================
  Files         322      322           
  Lines       39599    39599           
  Branches     8614     8614           
=======================================
+ Hits        35685    35687    +2     
+ Misses       2602     2600    -2     
  Partials     1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen merged commit 586227c into main May 30, 2024
32 checks passed
@jonathangreen jonathangreen deleted the bugfix/update-run-path-custom-list branch May 30, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants