Support running app.py with a base URL again.
#1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app.py
Outdated
| url = None | ||
| if len(sys.argv) > 1: | ||
| url = sys.argv[1] | ||
| url = sys.argv.pop() |
There was a problem hiding this comment.
This fails in the case where you don't pass in a URL right?
$ python app.py
Traceback (most recent call last):
File "palace/circulation/app.py", line 43, in <module>
run(url)
File "palace/circulation/app.py", line 29, in run
InstanceInitializationScript().run()
File "palace/circulation/src/palace/manager/scripts/initialization.py", line 175, in run
ArgumentParser(
File ".pyenv/versions/3.10.10/lib/python3.10/argparse.py", line 1717, in __init__
prog = _os.path.basename(_sys.argv[0])
IndexError: list index out of range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick fix to support running
app.pywith a base URL again. It justpops the URL argument from the command line args, so that futureArgParsers don't get confused by it and exit.Motivation and Context
app.pywith a URL would result inInstanceInitializationScript.run's arg parser erroring, because it wasn't expecting any args.How Has This Been Tested?
Checklist