Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tox-docker from 4.1.0 to 5.0.0 #1869

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 27, 2024

Bumps tox-docker from 4.1.0 to 5.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @jonathangreen.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels May 27, 2024
@jonathangreen jonathangreen requested a review from a team May 31, 2024 16:50
@jonathangreen
Copy link
Member

Because of the changes here: https://github.com/tox-dev/tox-docker?tab=readme-ov-file#upgrading

This directive was removed in tox-docker version 5.0. Use expose instead. The ability to map a container port to a specific host port was completely removed.

I had to do some work to support running our tests with tox-docker. For all our test configs that specify a URL, I made a new settings class that allows them to be specified in parts, or as the whole environment variable. We use the parts to run under tox docker, but keep the info about setting up the tests in the README the same, since it doesn't really make sense to set the environment variables like this outside of tox.

@jonathangreen
Copy link
Member

Requesting review from @ThePalaceProject/backend since this is a bigger change then the usual dependabot PR.

Copy link
Contributor

@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

dependabot bot and others added 3 commits May 31, 2024 14:07
Bumps [tox-docker](https://github.com/tox-dev/tox-docker) from 4.1.0 to 5.0.0.
- [Commits](https://github.com/tox-dev/tox-docker/commits)

---
updated-dependencies:
- dependency-name: tox-docker
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@jonathangreen jonathangreen force-pushed the dependabot/pip/tox-docker-5.0.0 branch from f9d3c53 to 850d032 Compare May 31, 2024 17:10
@jonathangreen
Copy link
Member

@dependabot squash and merge

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (586227c) to head (850d032).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   90.12%   90.05%   -0.08%     
==========================================
  Files         322      322              
  Lines       39599    39599              
  Branches     8614     6486    -2128     
==========================================
- Hits        35687    35659      -28     
- Misses       2600     2616      +16     
- Partials     1312     1324      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot merged commit 3d7ca1c into main May 31, 2024
20 checks passed
@dependabot dependabot bot deleted the dependabot/pip/tox-docker-5.0.0 branch May 31, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants