Add search classes to strict type checking #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
==========================================
- Coverage 90.12% 90.12% -0.01%
==========================================
Files 300 300
Lines 39563 39569 +6
Branches 8595 8595
==========================================
+ Hits 35657 35662 +5
Misses 2585 2585
- Partials 1321 1322 +1 ☔ View full report in Codecov by Sentry. |
tdilauro
approved these changes
May 14, 2024
src/palace/manager/search/service.py
Outdated
| for name in result.keys(): | ||
| if name.startswith(f"{self.base_revision_name}-"): | ||
| return name | ||
| return name # type: ignore[no-any-return] |
There was a problem hiding this comment.
Hmmm. It looks like name should be a str here.
There was a problem hiding this comment.
From what I could see client is untyped so self._client.indices.get_alias ends up giving us an Any type, which means name ends up being Any. I type hinted the returned dict, so we get a better type then Any.
jonathangreen
force-pushed
the
chore/add-type-hints-search-classes
branch
from
7c352bc to
e76cfec
Compare
jonathangreen
force-pushed
the
chore/add-type-hints-search-classes
branch
from
e76cfec to
7a8d100
Compare
jonathangreen
added a commit
that referenced
this pull request
May 24, 2024
* Add type hints to search classes * Set future annotations * Update to string annotations * Don't use recursive type references, due to ugly syntax and incompatibility with union operator * update type hint a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our search document classes were already typed, they were just missing a few hints necessary to add them to the list of classes that opt into strict type checking.
Motivation and Context
Since I'm working on these classes in PP-1225 I added the missing hints here.
How Has This Been Tested?
Checklist