Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger utility functions #1839

Merged
merged 1 commit into from
May 13, 2024
Merged

Add logger utility functions #1839

merged 1 commit into from
May 13, 2024

Conversation

jonathangreen
Copy link
Member

Description

Add a new logger utility function: logger_for_function and move logger_for_cls from a static method on LoggerMixin out to its own utility function.

Motivation and Context

Similar to #1838, I needed a couple of the lane creation functions to have a consistent logger name. It seemed helpful to add a new logger_for_function call so we can get a logger for this purpose.

How Has This Been Tested?

  • Tested running locally

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (dcb23df) to head (27bd35d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1839   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files         299      299           
  Lines       39530    39541   +11     
  Branches     8585     8584    -1     
=======================================
+ Hits        35618    35630   +12     
+ Misses       2590     2589    -1     
  Partials     1322     1322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵

@jonathangreen jonathangreen merged commit 530f25b into main May 13, 2024
21 checks passed
@jonathangreen jonathangreen deleted the feature/logger-mixin-util branch May 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants