Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search index rebuild script undefined variable #1836

Merged
merged 1 commit into from
May 10, 2024

Conversation

jonathangreen
Copy link
Member

Description

Small fix to search index rebuild script. It raising a undefined variable exception because self.services was being accessed before the parent __init__ function had been called to set it up.

Motivation and Context

Script was failing when trying to rebuild index.

How Has This Been Tested?

Tested locally.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen added the bug Something isn't working label May 10, 2024
@jonathangreen jonathangreen requested a review from a team May 10, 2024 15:52
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (7f01ee6) to head (9a4702d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1836   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files         299      299           
  Lines       39530    39530           
  Branches     8585     8585           
=======================================
  Hits        35619    35619           
+ Misses       2590     2589    -1     
- Partials     1321     1322    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛🦶🏽

@jonathangreen jonathangreen merged commit dcb23df into main May 10, 2024
20 checks passed
@jonathangreen jonathangreen deleted the bugfix/search-index-rebuild branch May 10, 2024 17:00
jonathangreen added a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants