Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WhereAreMyBooksScript test that was marked as skipped #1825

Merged
merged 1 commit into from
May 3, 2024

Conversation

jonathangreen
Copy link
Member

Description

Update the test_overall_structure test, and remove the skip mark on it. The main thing that was causing issues in the test was that the test DB wasn't being passed into the script initialization.

Took the time while I was looking at the test to replace the custom mock with a couple magic mock functions as well.

Motivation and Context

Nice to not have any tests marked as skipped.

How Has This Been Tested?

Running tests.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team May 3, 2024 15:09
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (81c439c) to head (5ade6fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   90.03%   90.06%   +0.03%     
==========================================
  Files         299      299              
  Lines       39543    39543              
  Branches     8588     8588              
==========================================
+ Hits        35603    35615      +12     
+ Misses       2613     2601      -12     
  Partials     1327     1327              
Flag Coverage Δ
manager 89.86% <ø> (+0.03%) ⬆️
migration 24.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen merged commit c9ce074 into main May 3, 2024
21 checks passed
@jonathangreen jonathangreen deleted the chore/fix-skipped-test branch May 3, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants