Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AUTOINITIALIZE env variable #1824

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

jonathangreen
Copy link
Member

Description

Since importing app no longer automatically initializes anything, we are able to clean up this conditional code.

Motivation and Context

Nice to not have our tests rely on env variables be set. After #1817 goes in, i believe there aren't any more environment variables we depend on to change test initialization.

How Has This Been Tested?

Running tests.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team May 3, 2024 15:04
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (81c439c) to head (8b7c6bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
+ Coverage   90.03%   90.05%   +0.01%     
==========================================
  Files         299      299              
  Lines       39543    39541       -2     
  Branches     8588     8588              
==========================================
+ Hits        35603    35609       +6     
+ Misses       2613     2606       -7     
+ Partials     1327     1326       -1     
Flag Coverage Δ
manager 89.85% <100.00%> (+0.01%) ⬆️
migration 24.53% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen merged commit 5776abe into main May 3, 2024
21 checks passed
@jonathangreen jonathangreen deleted the chore/remove-autoinitialize branch May 3, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants